Skip to content

feat(API): Implement figma attachments endpoints#415

Merged
Mikko Karkee (Varpuspaavi) merged 2 commits intomasterfrom
TSE-613
Oct 13, 2023
Merged

feat(API): Implement figma attachments endpoints#415
Mikko Karkee (Varpuspaavi) merged 2 commits intomasterfrom
TSE-613

Conversation

@Varpuspaavi
Copy link
Copy Markdown
Contributor

@Varpuspaavi Mikko Karkee (Varpuspaavi) commented Sep 27, 2023

@Varpuspaavi Mikko Karkee (Varpuspaavi) changed the title feat: Implement figma attachments endpoints feat(API): Implement figma attachments endpoints Sep 27, 2023
@Varpuspaavi Mikko Karkee (Varpuspaavi) marked this pull request as ready for review October 10, 2023 13:11
@Varpuspaavi
Copy link
Copy Markdown
Contributor Author

Reminder to self: I will bump GO before Bumping the CLI

Comment thread paths/figma_attachment_keys/create.yaml Outdated
---
summary: Attach the Figma attachment to a key
description: Attach the Figma attachment to a key
operationId: figma_attachment_key/create
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't it be more logical to add these operations to figma_attachments (or perhaps keys) instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted, not exactly sure if this is what you meant
CR

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, but they'd also have to live on paths/figma_attachments IMO

Copy link
Copy Markdown
Collaborator

@jablan jablan Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I guess the API PR has already been merged in phrase?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the API PR is merged. Can we have two create.yaml/destroy.yaml in the same folder? I could adjust this. On the API PR we agreed to not use custom named methods and instead went with second controller to have option for second create/destroy paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants